Skip to content

Add testing_buildBlockV1#9901

Draft
marcindsobczak wants to merge 18 commits intomasterfrom
feature/testing_build_block
Draft

Add testing_buildBlockV1#9901
marcindsobczak wants to merge 18 commits intomasterfrom
feature/testing_build_block

Conversation

@marcindsobczak
Copy link
Contributor

Implementing ethereum/execution-apis#710

Changes

  • PoC implementation of a new rpc endpoint testing_buildBlockV1

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej
Copy link
Member

What is the status of it compared to ethereum/execution-apis#747 ?

@marioevz
Copy link

I'm testing this in EELS, using execute command, and noticed that the call fails with:

JSONRPCError(code=-32602, message=Missing parameter does not have a default value. (Parameter 'parameters'), data=System.ArgumentException: Missing parameter does not have a default value. (Parameter 'parameters')
E      at System.Reflection.MethodBase.HandleTypeMissing(ParameterInfo paramInfo, RuntimeType sigType)
E      at System.Reflection.MethodBaseInvoker.InvokeWithManyArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
E      at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
E      at Nethermind.JsonRpc.JsonRpcService.ExecuteAsync(JsonRpcRequest request, String methodName, ResolvedMethodInfo method, JsonRpcContext context) in /nethermind/src/Nethermind/Nethermind.JsonRpc/JsonRpcService.cs:line 131)

if the last parameter is missing (extra data), however the spec mentions that required: false for this last parameter.

# Conflicts:
#	src/Nethermind/Nethermind.JsonRpc/Modules/ModuleType.cs
#	src/Nethermind/Nethermind.Merge.Plugin.Test/MergePluginTests.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants